-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new color picker & color field #5174
Create new color picker & color field #5174
Conversation
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace the existing usages of the old color picker with the new one, I would prefer not to have two different versions at the same time.
The validation message on invalid format in the old picker was "Das Format von entity.null.fields.color ist ungültig", while the new picker outputs "Could not parse #asdfas as a color. Missing a plugin?"
Using only the keyboard, I cannot open the dialog in the new colorfield. The swatch button isn't focusable for me.
The old api-colorpicker apparently happily saves #asdfas
as category color, and the category color input isn't displayed anymore from then on. Could we make sure to fix this in the new picker?
@carlobeltrame sorry this is not yet fully reviewable. Of course my goal is to replace the other colorpicker and have it completed to parity with the current one. I'll notify you when I'm ready.
yes should be fixed |
@carlobeltrame I figured, I'd rather have a separate color field that has no popup, just a text field and add a separate component with the picker. As soon as I fixed the tests, I'll replace the old color picker with the new one. |
Co-authored-by: Bacluc <lucius.bachmann@gmx.ch>
# Conflicts: # frontend/src/components/form/base/ColorPicker/ColorSwatch.vue # frontend/src/components/form/base/EColorPicker.vue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't look through all the code, yet. But purely from user testing seems to work as intended 😃
430cbf5
to
2dc78f2
Compare
2dc78f2
to
909f2d7
Compare
@usu can you have a look at it again? |
While trying to create a color field on the campCollaboration to be able to differentiate between users with (accidental) same colors, I realized that our colorpickers were not able to handle null values. I thought it would be best to implement the new colorpicker using the
EParseField
.Now the the parsefield needs 3 different value types: